3d-cube-SP: Avoid redeclaring static functions#66
Open
camillobruni wants to merge 1 commit intoWebKit:mainfrom
Open
3d-cube-SP: Avoid redeclaring static functions#66camillobruni wants to merge 1 commit intoWebKit:mainfrom
camillobruni wants to merge 1 commit intoWebKit:mainfrom
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This feels marginal to me since AFAIK minifiers wouldn't move such functions to the top level in production code. So, it's not clear what the value add of this is. |
Contributor
Author
|
Less about moving it to toplevel than having it being re-initialized on every run (though I agree, a minifier would probably do it differently). Maybe a separate namespace-like global that is reused would be more realistic? |
Contributor
|
But reinitialization of nested functions is very common in JS because minifiers don't hoist. I would hesitate to remove that from benchmarks unless it's being done in an unrealistic way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of functions in 3d-cube are nested inside
run()even though they don't close over anything.